Conversation
maribethb
approved these changes
Jun 30, 2026
| // so focusing the workspace as a whole lands on that target. | ||
| assert.equal( | ||
| Blockly.getFocusManager().getFocusedNode(), | ||
| this.workspace.getWorkspaceFocusTarget(), |
Contributor
There was a problem hiding this comment.
Does getFocusableNode on the workspace return this element correctly? If so then using that would sort of future-proof this test since we don't care what the specific element that's focused, just that it's the one that represents the workspace being focused
Contributor
Author
There was a problem hiding this comment.
No, the workspace focus target is a separate focusable node and DOM element from the workspace, and the workspace's focusable element is still its root SVG group. The focus target gets used here because it's returned from WorkspaceSvg.getRestoredFocusableNode(); I updated the test to use that rather than hardcoding the focus target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR updates the v13 branch to use Blockly v13.1.0 and fixes a couple of test failures.